Add a warning for is to anticipate using it as a keyword#5229
Merged
laurmaedje merged 1 commit intotypst:mainfrom Oct 31, 2024
Merged
Add a warning for is to anticipate using it as a keyword#5229laurmaedje merged 1 commit intotypst:mainfrom
is to anticipate using it as a keyword#5229laurmaedje merged 1 commit intotypst:mainfrom
Conversation
MDLC01
reviewed
Oct 18, 2024
Member
|
It's unfortunate that we don't have warning support in the parser because this doesn't really belong in eval. |
Co-authored-by: Malo <57839069+MDLC01@users.noreply.github.com>
Member
|
Thanks! |
This was referenced Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mostly discussed in the syntax forge of the Discord. There is support among a number of contributors for adding
isas a keyword for pattern matching of expressions in a future version, so this PR adds a warning about using it as an identifier to make it easier to avoid errors in future (since it will not be allowed as an identifier when it is a keyword).