fix: ToUnicode in PDF should describe CID instead of GID#3435
Merged
laurmaedje merged 2 commits intotypst:mainfrom Feb 17, 2024
Merged
fix: ToUnicode in PDF should describe CID instead of GID#3435laurmaedje merged 2 commits intotypst:mainfrom
ToUnicode in PDF should describe CID instead of GID#3435laurmaedje merged 2 commits intotypst:mainfrom
Conversation
laurmaedje
reviewed
Feb 17, 2024
Member
|
Great, thanks for the fix! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3416
ToUnicodemakes it possible to copy and search text in PDF. Previous implementation assumes CIDs (Character IDs) and GIDs (Glyph IDs) are the same in the font, but they may differ. For example, if youtestit cjk --pdfand copy texts in the generated PDFs, you will find���. This PR fixes it.