Part 5a: Gradients on text with relative: auto or relative: "parent"#2364
Merged
laurmaedje merged 10 commits intotypst:mainfrom Oct 12, 2023
Merged
Part 5a: Gradients on text with relative: auto or relative: "parent"#2364laurmaedje merged 10 commits intotypst:mainfrom
relative: auto or relative: "parent"#2364laurmaedje merged 10 commits intotypst:mainfrom
Conversation
PgBiel
reviewed
Oct 12, 2023
Co-authored-by: Pg Biel <9021226+PgBiel@users.noreply.github.com>
Contributor
Author
|
@laurmaedje Before merging, there is an issue with PDF conic gradients on text, you can already merge and I’ll fix it in a second PR, or you can wait until I fix it in this one. The issue is very insignificant: the angle correction is wrong in PDF. |
Member
|
I'll wait. I haven't reviewed yet, will do that now. |
laurmaedje
reviewed
Oct 12, 2023
laurmaedje
reviewed
Oct 12, 2023
Co-authored-by: Laurenz <laurmaedje@gmail.com>
Co-authored-by: Laurenz <laurmaedje@gmail.com>
Co-authored-by: Laurenz <laurmaedje@gmail.com>
Member
|
Thank you! 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #2282
This introduces the ability to set gradients on text but only with the "relativeness" being set to the parent (or auto). Since glyph-by-glyph might be quite difficult to get merged (it will most likely require some discussion), I am opening this first PR. Gradients on text are simply used by setting the
fillparam of text.This PR also adds a number of fixes to the way container transform matrices are handled in all three targets and fixes major bug in all three. While these bug were almost impossible to trigger with gradients on fill they became quite obvious on text (as it broke the gradients altogether).