Ensure normal weight math font face is consistent#1774
Merged
laurmaedje merged 3 commits intotypst:mainfrom Aug 2, 2023
Merged
Ensure normal weight math font face is consistent#1774laurmaedje merged 3 commits intotypst:mainfrom
laurmaedje merged 3 commits intotypst:mainfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, Typst uses New Computer Modern Math at weight 450 for its math font. This results in NewComputerModernMath-Book as the default font. However, sometimes NewComputerModernMath-Regular (font weight 400) sneaks in.
There are two fonts in the file:
The
login the beginning is Book weight, and thelogin the numerator is Regular weight (look at the thinnest spots on theos and the upper-right decorations on thegs). Bothxs, on the other hand, are Book weight; this isn't a design choice that stuff in denominators should have lesser weight. Instead, there are currently multiple pathways for rendering text in math, and one of them is accidentally overriding the initial weight of 450.This PR ensures that the meaning of "normal" font weight is tied to the font weight initially selected for the math font.
A number of reference test images needed to be updated. The only changes were that text in some circumstances became a little heavier.
After