chore(website): [playground] add support for extends, ts types and more#6656
chore(website): [playground] add support for extends, ts types and more#6656
Conversation
|
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
❌ Deploy Preview for typescript-eslint failed.
|
|
@JoshuaKGoldberg when you find some time can you do preliminary review on this? |
|
I will... try 🥺 😅 |
|
cc @jakebailey @orta - if either or both of you have time, this PR might be of interest to you. See in particular the |
There was a problem hiding this comment.
Yeah @armano2 this is fantastic, really great stuff! It works smoothly and the new features (types, scopes, file type, ...) are awesome.
I mainly looked at how the PlaygroundRoot component along with the component & hooks it uses. Also the new build scripts.
My biggest point of feedback would be that if you can split up the changes at all that would be really helpful for reviewing. It's a big one 😄. But if not I think it's a direct step in many positive directions from the site today, and it'd be also great to work from what's here.
LMK when it's ready for a full review! 🙌
|
I will try to split this PR up a little |
|
would it be possible to rebase this against the |
71b04b7 to
20ff467
Compare
|
@bradzacher changes rebased |
0894262 to
6aaf43a
Compare
|
👋 ping @armano2, do you still have time / plans to work on this? |
|
Closing out this old draft PR to keep the queue small. 🧹 |
PR Checklist
Overview
New features
TODO: explain what changed