Skip to content

fix(scope-manager): export ClassStaticBlockScope#12460

Merged
JoshuaKGoldberg merged 1 commit into
typescript-eslint:mainfrom
zaewc:fix/12459
Jul 1, 2026
Merged

fix(scope-manager): export ClassStaticBlockScope#12460
JoshuaKGoldberg merged 1 commit into
typescript-eslint:mainfrom
zaewc:fix/12459

Conversation

@zaewc

@zaewc zaewc commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

ClassStaticBlockScope was part of the internal scope model but missing from the public @typescript-eslint/scope-manager barrel export

This PR exports it and adds a regression test to ensure it can be imported from the package entrypoint

@typescript-eslint

Copy link
Copy Markdown
Contributor

Thanks for the PR, @zaewc!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 56ac2ea
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6a4362f4a7882800082ca8b0
😎 Deploy Preview https://deploy-preview-12460--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud

nx-cloud Bot commented Jun 30, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 56ac2ea

Command Status Duration Result
nx run-many -t typecheck:tsgo ✅ Succeeded 50s View ↗
nx run-many -t lint --projects=typescript-estre... ✅ Succeeded 53s View ↗
nx run-many -t lint --projects=eslint-plugin --... ✅ Succeeded 39s View ↗
nx run-many -t typecheck ✅ Succeeded 44s View ↗
nx run-many -t lint --projects=ast-spec,utils,s... ✅ Succeeded 33s View ↗
nx run-many -t lint --projects=parser,type-util... ✅ Succeeded 29s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
Additional runs (23) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-06-30 06:36:09 UTC

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.24%. Comparing base (3ea32f4) to head (56ac2ea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12460      +/-   ##
==========================================
+ Coverage   87.06%   91.24%   +4.17%     
==========================================
  Files         514      472      -42     
  Lines       16616    14503    -2113     
  Branches     5193     4595     -598     
==========================================
- Hits        14467    13233    -1234     
+ Misses       1461      752     -709     
+ Partials      688      518     -170     
Flag Coverage Δ
unittest 91.24% <ø> (+4.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/scope-manager/tests/lib.test.ts Outdated
@StyleShit StyleShit added the awaiting response Issues waiting for a reply from the OP or another party label Jun 30, 2026
@github-actions

Copy link
Copy Markdown

Hi @zaewc, thanks for the update!

Just a quick heads-up: please try to avoid force-pushing moving forward. Rewriting history makes it harder for us to track incremental changes between reviews.

Since we squash merge anyway, there is no need to keep the commit history "clean" on this branch. Standard pushes are much preferred!

@zaewc

zaewc commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Hi @zaewc, thanks for the update!

Just a quick heads-up: please try to avoid force-pushing moving forward. Rewriting history makes it harder for us to track incremental changes between reviews.

Since we squash merge anyway, there is no need to keep the commit history "clean" on this branch. Standard pushes are much preferred!

Thanks for the heads-up and sorry about the force push

I rewrote the branch to remove the temporary test commit after addressing the review, but I understand that this makes review history harder to follow. I’ll avoid force-pushing on future updates and use regular follow-up commits instead.

@StyleShit StyleShit removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 30, 2026
@StyleShit StyleShit enabled auto-merge (squash) June 30, 2026 06:37
@StyleShit StyleShit added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 30, 2026
@JoshuaKGoldberg

Copy link
Copy Markdown
Member

This PR exports it and adds a regression test to ensure it can be imported from the package entrypoint

@zaewc note https://typescript-eslint.io/contributing/ai-policy 🙂

@JoshuaKGoldberg JoshuaKGoldberg disabled auto-merge July 1, 2026 12:17
@JoshuaKGoldberg JoshuaKGoldberg merged commit ee39789 into typescript-eslint:main Jul 1, 2026
52 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: ClassStaticBlockScope is not exported from @typescript-eslint/scope-manager

3 participants