Skip to content

chore(eslint-plugin): switch auto-generated test cases to hand-written in return-await.test.ts#12224

Merged
JoshuaKGoldberg merged 1 commit into
typescript-eslint:mainfrom
Vinccool96:chore/11049-return-await-handwritten
Apr 17, 2026
Merged

chore(eslint-plugin): switch auto-generated test cases to hand-written in return-await.test.ts#12224
JoshuaKGoldberg merged 1 commit into
typescript-eslint:mainfrom
Vinccool96:chore/11049-return-await-handwritten

Conversation

@Vinccool96

@Vinccool96 Vinccool96 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

  • Change dynamic test cases using spread and map to handwritten ones
  • Zero (0) existing recurring cases have been removed
  • No further recurring cases exist

@typescript-eslint

typescript-eslint Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR, @Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify

netlify Bot commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit 8cb4211
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/69e0f4c5705fdd00080e72f8

@nx-cloud

nx-cloud Bot commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 8cb4211

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 2m 9s View ↗
nx run-many -t typecheck ✅ Succeeded 42s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded 3s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run generate-configs ✅ Succeeded 5s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 2s View ↗
Additional runs (34) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2026-04-16 14:48:45 UTC

@Vinccool96

Vinccool96 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

@JoshuaKGoldberg Why is Netlify failing?

@JoshuaKGoldberg

JoshuaKGoldberg commented Apr 17, 2026

Copy link
Copy Markdown
Member

I don't know. We can ignore it. 🤷

10:40:51 AM: {
10:40:51 AM:   detail: undefined,
10:40:51 AM:   id: '',
10:40:51 AM:   location: {
10:40:51 AM:     column: 22,
10:40:51 AM:     file: 'src/index.js',
10:40:51 AM:     length: 66,
10:40:51 AM:     line: 13,
10:40:51 AM:     lineText: "import rawPlugin from '@typescript-eslint/eslint-plugin/use-at-your-own-risk/raw-plugin';",
10:40:51 AM:     namespace: '',
10:40:51 AM:     suggestion: ''
10:40:51 AM:   },
10:40:51 AM:   notes: [
10:40:51 AM:     {
10:40:51 AM:       location: [Object],
10:40:51 AM:       text: 'The module "./dist/raw-plugin.js" was not found on the file system:'
10:40:51 AM:     },
10:40:51 AM:     {
10:40:51 AM:       location: null,
10:40:51 AM:       text: 'You can mark the path "@typescript-eslint/eslint-plugin/use-at-your-own-risk/raw-plugin" as external to exclude it from the bundle, which will remove this error and leave the unresolved path in the bundle.'
10:40:51 AM:     }
10:40:51 AM:   ],
10:40:51 AM:   pluginName: '',
10:40:51 AM:   text: 'Could not resolve "@typescript-eslint/eslint-plugin/use-at-your-own-risk/raw-plugin"'
10:40:51 AM: }

If it keeps happening that'd be a good separate/followup issue.

JoshuaKGoldberg
JoshuaKGoldberg reviewed Apr 17, 2026
View reviewed changes
Comment thread eslint-suppressions.json
"@typescript-eslint/internal/no-dynamic-tests": {
"count": 1
}
},

@JoshuaKGoldberg JoshuaKGoldberg Apr 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Praise] Yay!

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 17, 2026
View reviewed changes

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "age of AI", it's nice to see a PR from a reliable contributor who we know keeps doing great work consistently. Thanks @Vinccool96! ❤️

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6d599b4 into typescript-eslint:main Apr 17, 2026
57 of 61 checks passed
@Vinccool96 Vinccool96 deleted the chore/11049-return-await-handwritten branch April 17, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: [return-await.test.ts] Switch auto-generated test cases to hand-written

2 participants

@Vinccool96 @JoshuaKGoldberg