🤖 User test baselines have changed for omit-on-indexable-type#142
Open
typescript-bot wants to merge 2 commits intouser-baseline-updatesfrom
Open
🤖 User test baselines have changed for omit-on-indexable-type#142typescript-bot wants to merge 2 commits intouser-baseline-updatesfrom
typescript-bot wants to merge 2 commits intouser-baseline-updatesfrom
Conversation
weswigham
reviewed
Jan 27, 2021
| @@ -0,0 +1,12 @@ | |||
| Exit Code: 2 | |||
| Standard output: | |||
| lib/util/cleverMerge.js(538,3): error TS2322: Type 'T' is not assignable to type 'Omit<T, P>'. | |||
Collaborator
There was a problem hiding this comment.
sigh yeah, might need full assignability rules for .nameType- having mapped types before we can ship this change, rather than just comparability rules.
2d08609 to
60b1907
Compare
77b2149 to
6a4fdd0
Compare
6a4fdd0 to
97ceb71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on microsoft#42524
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham