Adjust conduct logs default lines fetched to be 50 when follow is enabled#549
Merged
fsat merged 1 commit intotypesafehub:masterfrom Oct 13, 2017
Merged
Adjust conduct logs default lines fetched to be 50 when follow is enabled#549fsat merged 1 commit intotypesafehub:masterfrom
conduct logs default lines fetched to be 50 when follow is enabled#549fsat merged 1 commit intotypesafehub:masterfrom
Conversation
…nabled so that reconciliation is less likely to fail.
fsat
approved these changes
Oct 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the default value for
linesforconduct logswhen-fis provided. This is done so that reconciliation of the logs is less likely to fail.Failure can and will happen when log volume is high, as the CLI needs to calculate the difference between old and new logs to determine which lines to print. By increasing the default size, we're making this less likely to happen.