Add missing return False for HTTP error supression#545
Merged
longshorej merged 1 commit intotypesafehub:masterfrom Aug 28, 2017
Merged
Add missing return False for HTTP error supression#545longshorej merged 1 commit intotypesafehub:masterfrom
return False for HTTP error supression#545longshorej merged 1 commit intotypesafehub:masterfrom
Conversation
ashutoshraina
approved these changes
Aug 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CLI fixes a small bug in the CLI where one case wasn't returning
Falsewhen contractually it should have been. This manifested in aNone-related error when runningconduct logsinstead of a proper error message.