Merged
Conversation
…ith "conductr" in the name
huntc
approved these changes
Aug 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the service name used for DC/OS requests to be detected based on the running Marathon services.
The net result here is that you could have services
conductr-2.1.5andconductr-2.1.6, and the CLI will work out-of-the-box by selecting the first returned from the Marathon API. It's backwards compatible as well -- a service name ofconductrwill still work too.By merging this PR, we can move toward embedding the version in the service name so that we have a nice solution for upgrading ConductR on DC/OS.