Fix sandbox network interface alias calculation on linux when launching with 10 or more instances#537
Merged
huntc merged 1 commit intotypesafehub:masterfrom Aug 11, 2017
Conversation
…ng with 10 or more instances
huntc
approved these changes
Aug 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug with
sandbox runwhere if specifying large-nvalues (such as 10), the interface name would wrap around. Now, we ensure that it's calculated using the entire last component of the IP address instead of just the last digit.Manual test was completed successfully with
-n 15.