Fix conduct load creating empty bundle configuration#524
Merged
fsat merged 1 commit intotypesafehub:masterfrom Jul 20, 2017
Merged
Fix conduct load creating empty bundle configuration#524fsat merged 1 commit intotypesafehub:masterfrom
fsat merged 1 commit intotypesafehub:masterfrom
Conversation
When `conduct load <bundle>` is invoked, empty configuration is created. Once the expected empty `bndl` argument for `roles` is updated from `None` to empty array within `conduct load`, the empty configuration is no longer created.
Contributor
Author
|
Fixes #521 |
Contributor
Author
|
I will post manual test shortly. |
markusjura
approved these changes
Jul 20, 2017
Contributor
Author
|
Manual test is done successfully. Loading bundle no longer loads any config. Start the sandbox. Load a bundle. Bundle is loaded without config. |
longshorej
reviewed
Jul 20, 2017
| # evaluate to True. We check for an attribute that normally isn't present to detect this. | ||
| if hasattr(args, '_no_bndl_') and getattr(args, '_no_bndl_'): | ||
| return False | ||
|
|
Contributor
There was a problem hiding this comment.
Thanks (and sorry) for fixing that mess! ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
conduct load <bundle>is invoked, empty configuration is created.Once the expected empty
bndlargument forrolesis updated fromNoneto empty array withinconduct load, the empty configuration is no longer created.