Adjust bintray resolver credentials to honor realm values#514
Merged
fsat merged 1 commit intotypesafehub:masterfrom Jun 28, 2017
Merged
Adjust bintray resolver credentials to honor realm values#514fsat merged 1 commit intotypesafehub:masterfrom
fsat merged 1 commit intotypesafehub:masterfrom
Conversation
ce1fbef to
c00f469
Compare
fsat
approved these changes
Jun 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the Bintray resolver only uses credentials if realm is omitted or equal to
Bintray. Values following other realm declarations are omitted.Fixes #507
Manual Test
Ensure that the test below fails on
master, then rerun and ensure it passes with this PR.