Ensure that the current working directory exists or exit with intelligible error#513
Merged
huntc merged 1 commit intotypesafehub:masterfrom Jun 29, 2017
Merged
Conversation
intelligible error
Contributor
|
@longshorej - I think this is a friendlier behaviour compared to currently released behaviour, so I'm for it. I'd like to hear what others have to say, though. So I'll leave this comment here for now. |
huntc
approved these changes
Jun 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check when the CLI starts to ensure the current working directory exists. This can help mitigate weird environmental issues, I know I've launched the CLI from unlinked directories and it wasn't clear what was wrong.
Fixes #502.
Manual test