New sandbox version notification#510
Conversation
360dc5d to
d74981f
Compare
d74981f to
fd2637b
Compare
|
Manual Test: ConductR 2.1 Manual test is completed successfully. Latest version of 2.1 is removed from cache. When the older version is started, the upgrade message is displayed at the end of the We'll start the latest version of Sandbox. This will download the latest sandbox into the cache. And then when the older version of sandbox is restarted, the warning message is not displayed as latest sandbox is present in the cache directory. |
|
Manual Test: Native executable Manual test is completed successfully. Rebuild the Latest version of 2.1 is removed from cache. When the older version is started, the upgrade message is displayed at the end of the We'll start the latest version of Sandbox. This will download the latest sandbox into the cache. And then when the older version of sandbox is restarted, the warning message is not displayed as latest sandbox is present in the cache directory. |
|
Manual Test: Upgrade check without Bintray Credentials Manual test is completed successfully. Latest version of 2.1 is removed from cache. Remove the current Bintray Credentials. When the older version is started, the upgrade message is displayed at the end of the We'll start the latest version of Sandbox. This will download the latest sandbox into the cache. And then when the older version of sandbox is restarted, the warning message is not displayed as latest sandbox is present in the cache directory. Put the credentials back at the end of the test. |
|
Manual Test: ConductR 2.0 Manual test is completed successfully. Latest version of 2.1 is removed from cache. When the older version is started, the upgrade message is displayed at the end of the We'll start the latest version of And then when the older version of sandbox is restarted, the warning message is not displayed as latest |
markusjura
left a comment
There was a problem hiding this comment.
Overall, looks good. One comment in regards to the messaging.
| upgrade_requirements = run_result.sandbox_upgrade_requirements | ||
| latest_version_str = format_version(upgrade_requirements.latest_version) | ||
| log.info('') | ||
| log.warning('Please upgrade to sandbox version {} by running'.format(latest_version_str)) |
There was a problem hiding this comment.
What about changing the naming to:
log.info('')
log.warning('A newer ConductR version is available. Please upgrade the sandbox to {} by running'.format(latest_version_str))
log.warning(' sandbox run {}'.format(latest_version_str))
This messaging sounds less harsh and only provides the information that a newer version is available instead of requesting that the user needs to upgrade.
There was a problem hiding this comment.
Thanks @markusjura - I knew you'd come up with a better message than me :-)
Notify end user when a newer sandbox version is available. Notification will be displayed when: - There's a newer version of sandbox compared to what is currently being run by `sandbox run`. - The user has not downloaded the newer version of sandbox.
fd2637b to
625e8a6
Compare
Notify end user when a newer sandbox version is available.
Notification will be displayed when:
sandbox run.