Skip to content

Improved error reporting for OS X reverser dns lookup#496

Merged
huntc merged 1 commit intotypesafehub:masterfrom
huntc:jvm-error-report
Jun 15, 2017
Merged

Improved error reporting for OS X reverser dns lookup#496
huntc merged 1 commit intotypesafehub:masterfrom
huntc:jvm-error-report

Conversation

@huntc
Copy link
Copy Markdown
Contributor

@huntc huntc commented Jun 15, 2017

Less scary.

@huntc
Copy link
Copy Markdown
Contributor Author

huntc commented Jun 15, 2017

Sample output:

huntc$ sandbox run 2.1.0 --no-default-features
Error: 
	Unfortunately, because of a known Java 8 issue on macOS,
	hostname lookups on your machine will take more than 5 seconds.

	This will prevent ConductR from starting.

	Fortunately, there is an easy, quick fix. Just add 'ChristohersMBP2.lan' to your /etc/hosts file. e.g.:

		127.0.0.1   localhost ChristohersMBP2.lan
		::1         localhost ChristohersMBP2.lan

	Note that you will need to use sudo to edit the /etc/hosts file.
	Use your favorite editor to do this e.g. 'sudo vi /etc/hosts'

	To learn more about the Java 8 issue: http://stackoverflow.com/questions/39636792/jvm-takes-a-long-time-to-resolve-ip-address-for-localhost

huntc$

fsat
fsat suggested changes Jun 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@fsat fsat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change itself lgtm - but I think we should continue asserting the output of the message.

Comment thread conductr_cli/test/test_validation.py Outdated
|Error: ::1 localhost MagicBox
|"""))
self.assertEqual(self.output(stderr), expected_output)
self.assertTrue(len(self.output(stderr)) > 0)
Copy link
Copy Markdown
Contributor

@fsat fsat Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should continue asserting the message, especially since there is part of the message where the socket.gethostname is being inserted in the message.

Copy link
Copy Markdown
Contributor Author

@huntc huntc Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree - it is quite painful to maintain such tests...

@huntc huntc force-pushed the jvm-error-report branch from d55b349 to 2eda614 Compare June 15, 2017 00:46
@huntc huntc force-pushed the jvm-error-report branch from 2eda614 to b1c7301 Compare June 15, 2017 00:57
@huntc huntc merged commit aa9733d into typesafehub:master Jun 15, 2017
@huntc huntc deleted the jvm-error-report branch June 15, 2017 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JustinPihony JustinPihony JustinPihony approved these changes

+1 more reviewer

@fsat fsat fsat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntc @JustinPihony @fsat