Refactor bndl so that component configurations are modified more consistently between different input types#494
Merged
huntc merged 1 commit intotypesafehub:masterfrom Jun 15, 2017
Conversation
…istently between different input types
Contributor
Author
Manual TestsOmitting description should result in
|
Contributor
Author
huntc
approved these changes
Jun 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
bndlso that it behaves more consistently between component types. Notably, there's two changes here:--component-descriptionremoved in favor of--descriptionthat now works with all component types, not just OCI, consistent with other flags like--endpointand--volume.The arguments are processed centrally in
bndl_create.pywhereas prior to this, for OCI/Docker inputs, they were processed in two places. This makes OCI inputs less special and more consistent with the other formats.Fixes #491