Allow variable substitutions in --env arguments for bndl tool#489
Merged
huntc merged 1 commit intotypesafehub:masterfrom Jun 12, 2017
Merged
Allow variable substitutions in --env arguments for bndl tool#489huntc merged 1 commit intotypesafehub:masterfrom
--env arguments for bndl tool#489huntc merged 1 commit intotypesafehub:masterfrom
Conversation
5743942 to
68714a0
Compare
huntc
approved these changes
Jun 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the format for generated
exportstatements when runningbndl --env. Whereas we previously enclosed values in single-quotes (thus preserving literal values), we now enclose in double quotes to allow variable substitution.This allows syntax like the following to work as expected:
conduct load confluentinc/cp-kafka:3.2.1--env 'KAFKA_ADVERTISED_LISTENERS=PLAINTEXT://$BUNDLE_HOST_IP:9092'