Hi, are there any updates on this or is there something i could help out with? Would love to get support for the new driver soon 😃

Hi, are there any updates on this or is there something i could help out with? Would love to get support for the new driver soon 😃

Hi, I would like some help, thanks.

We need to find how force mongo to stop create the _id field when collection is created, because mongo is always creating now this field : https://www.mongodb.com/docs/manual/core/document/#the-_id-field

So, if there is a entity with an other id name field the mongo will create _id field, like this example:

The result is:

Hi, i looked through the code and it seems like this behaviour is related to this issue: #9727

The additional .save() calls always results in an insert because the condition of whether it should be updated never matches. This is because the resulting transformed entities of the findByIds query in SubjectDatabaseEntityLoader don't contain an id property but the subject entity does.

Because it has no id the following happens:

1. findByPersistEntityLike fails to match the result to the subject
2. subject.databaseEntity is skipped
3. subject.databaseEntityLoaded is set to true
4. SubjectExecutor only finds a subject to be inserted instead of updated because it has no databaseEntity

I think the fix would be to check for the propertyName of the ObjectIdColumn instead of only the databaseNameWithoutPrefixes in the DocumentEntityTransformer transform:

...
        // handle _id property the special way
        if (metadata.objectIdColumn) {
            const { databaseNameWithoutPrefixes, propertyName } =
                metadata.objectIdColumn

            const documentIdWithoutPrefixes =
                document[databaseNameWithoutPrefixes]
            const documentIdWithPropertyName = document[propertyName]

            if (documentIdWithoutPrefixes) {
                entity[propertyName] = documentIdWithoutPrefixes
                hasData = true
            } else if (documentIdWithPropertyName) {
                entity[propertyName] = documentIdWithPropertyName
                hasData = true
            }
        }
...

This now adds the id from the document to the entity and results in an update to the same entity instead of an insert.
I pushed my changes and created a pr for your branch 👍

tgrassl

Thank you for your help dude!

@pleerock
Can you do the review please?

There is an error Oracle test, but we didn't any changes on Oracle source

@pleerock I would like to update the typings, so everyone can now use the official typings already included in the mongodb package. This would also finally remove the confusion around ObjectId and ObjectID (e.g. #2238)

As far i can see, i cannot use import { ObjectId } from 'mongodb' inside the following files, because that would require non-mongodb users to install mongodb right?

• EntityManager.ts
• Repository.ts
• BaseEntity.ts
• EntityId.ts
• FindOptionsOrder.ts
• FindOptionsRelations.ts
• FindOptionsSelect.ts
• FindOptionsWhere.ts

These all just need the type of the ObjectId. Mongo specific files like MongoEntityManager already import from mongodb, so I guess they are ok.
My idea would be to only copy the ObjectId typings into typeorm but not export it from the package, so these files can use that internal type. Would that be fine for you?

These all just need the type of the ObjectId. Mongo specific files like MongoEntityManager already import from mongodb, so I guess they are ok.

No, we must not have imports from mongodb anywhere, because non-monogdb users will have tsc errors and they'll be forced to install mongodb package even if they don't use it. That's bad.

@MatheusMeloAntiquera how about not submitting the same changes in separate PRs?
I've added you and @tgrassl to my fork. May we close this PR then?
(Also it would be nice to not commit my changes just by copying them on your branch. Instead pull the commits of collaborators on your branch to keep a clean commit history.)

@MatheusMeloAntiquera how about not submitting the same changes in separate PRs? I've added you and @tgrassl to my fork. May we close this PR then? (Also it would be nice to not commit my changes just by copying them on your branch. Instead pull the commits of collaborators on your branch to keep a clean commit history.)

I will keep this PR, sorry for copy your code I wanted to resolve this quickly, but you should have create a PR to my branch, not directly to typeorm repository