fix: wrong entity transform of relation id when referenced column is a primary key #8959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…also a primary key
This was referenced May 4, 2022
Contributor
Author
|
@pleerock any estimate when somebody from your team can review this fix? We had a big project and we add more and more workarounds in our project to fix this issue. I don't want to stress. It's only a question :) |
Member
|
I had to simplify your test to be able to understand the problem better. So yes, I can say the solution fixes the problem, however it touches very fragile code in the codebase, which obviously needs to be better than what we currently have. I'll merge this PR. Thanks for the contribution. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8892
May be fix: #8045
Fix wrong entity transform of relation id when referenced column is also a primary key.
Description of change
Only create value map if column isn't a primary key.
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000Documentation has been updated to reflect this change