Skip to content

Conversation

@gintsgints
Copy link

For you to review.

@gintsgints
Copy link
Author

gintsgints commented May 4, 2017

Guilty was this one:

"sample3_post_metadata"."description" AS "sample3_post_metadata_description" 

Of course you can shorten also table name. Wish me go that way?

@pleerock
Copy link
Member

shortening column names isnt a fix there. Do you expect users would be pleasured to do so too? We need some good fix. I don't understand why oracle support on aliases length is so limited.

@gintsgints
Copy link
Author

May be we can generate aliases somehow shorter?

@pleerock
Copy link
Member

ahhh Im not sure... Do you have any ideas?

@gintsgints
Copy link
Author

gintsgints commented May 19, 2017

Hmm just a question. Why you need to give them aliases at all?

@pleerock
Copy link
Member

ahhh thats a long story.... we need aliases to map data correctly to entities. You need to learn code of QueryBuilder and RawSqlResultsToEntityTransformer to understand why they are needed.

@pleerock
Copy link
Member

Probably we have only one way of fixing this - shorten them. But im not sure what is effective way of doing this. Maybe cut half of table name and column name in query builder? Not really sure. Is there any way we can increase alias length in oracle via orm?

Also, if you are planning to work on QB I recommend to switch to this branch, because there are latest changes of everything

@gintsgints
Copy link
Author

How about giving them numbers? Like Alias1, Alias2, .... AliasN

@pleerock
Copy link
Member

pleerock commented Jun 1, 2017

we can try numbers, however it will make things much much more complicated. And its already quite complicated

@pleerock
Copy link
Member

@gintsgints we are planning to finish complete oracle support in 0.2.0. @AlexMesser already fixed most of issues oracle has on his own branch. Soon all those changes will be landed in next and final 0.2.0 will be released next month. Thank you very much for your contribution.

@pleerock pleerock closed this Dec 13, 2017
@f-wrobel f-wrobel mentioned this pull request Jan 11, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants