Improve Repository.save() return type #2796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a new entity with
repository.save(fields), the current type definition fails to return to me the right fields types for the generated columns, for example:This seems to only make sense when
reload: falseis sent, which is not the case.This little change fixes that, while overriding the optional type when the values are present.
I'm not sure if this breaks some special case, maybe some maintainer could look into this 😅