Search code, repositories, users, issues, pull requests...

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

      const poolOptions: any = {
          maxConnectedOrPooled:
              this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
              this.options.poolSize ??
              10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
          maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
      }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

3. hanaClientDriver fallback removed 🐞 Bug ⛯ Reliability

Description

loadDependencies() now only checks options.driver, so projects still using the deprecated
hanaClientDriver option will have their provided client ignored and may throw
DriverPackageNotInstalledError if @sap/hana-client isn’t installed.

Code

src/driver/sap/SapDriver.ts[889-908]
src/driver/sap/SapDataSourceOptions.ts[19-24]

+        const client = this.options.driver
      if (client) {
          this.client = client

Evidence

The driver injection path now exclusively uses options.driver and the SAP options interface no
longer includes hanaClientDriver, meaning older configuration will no longer inject a client. When
driver is absent, loadDependencies() falls back to loading @sap/hana-client, which fails if
the package isn’t installed.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Older configs using the deprecated `hanaClientDriver` will no longer inject their provided driver, and may unexpectedly attempt to require `@sap/hana-client`.
### Issue Context
Even if TypeScript types no longer include `hanaClientDriver`, runtime configs (JS users, `as any`, env-based config readers) may still pass it. Silent ignore + fallback-to-require can cause confusing production failures.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-908]
### Suggested approach
- Detect `(this.options as any).hanaClientDriver` at runtime.
- Either:
- Throw a clear error: &amp;amp;quot;`hanaClientDriver` was removed; use `driver` instead&amp;amp;quot;, OR
- Temporarily support it with `const client = this.options.driver ?? (this.options as any).hanaClientDriver` and log a one-time deprecation warning.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

View more (15)

4. Undocumented hanaClientDriver removal 📘 Rule violation ✓ Correctness

Description

The PR removes previously-supported (even if deprecated) SAP driver options and fallback behavior
without any accompanying documentation updates. This can break existing configurations and leaves
users without guidance on required migration changes.

Code

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

5. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

     const poolOptions: any = {
         maxConnectedOrPooled:
             this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
             this.options.poolSize ??
             10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
         maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
     }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

6. Undocumented hanaClientDriver removal 📘 Rule violation ✓ Correctness

Description

The PR removes previously-supported (even if deprecated) SAP driver options and fallback behavior
without any accompanying documentation updates. This can break existing configurations and leaves
users without guidance on required migration changes.

Code

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

7. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

     const poolOptions: any = {
         maxConnectedOrPooled:
             this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
             this.options.poolSize ??
             10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
         maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
     }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

8. hanaClientDriver fallback removed 🐞 Bug ⛯ Reliability

Description

loadDependencies() now only checks options.driver, so projects still using the deprecated
hanaClientDriver option will have their provided client ignored and may throw
DriverPackageNotInstalledError if @sap/hana-client isn’t installed.

Code

src/driver/sap/SapDriver.ts[889-908]
src/driver/sap/SapDataSourceOptions.ts[19-24]

+        const client = this.options.driver
     if (client) {
         this.client = client

Evidence

The driver injection path now exclusively uses options.driver and the SAP options interface no
longer includes hanaClientDriver, meaning older configuration will no longer inject a client. When
driver is absent, loadDependencies() falls back to loading @sap/hana-client, which fails if
the package isn’t installed.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Older configs using the deprecated `hanaClientDriver` will no longer inject their provided driver, and may unexpectedly attempt to require `@sap/hana-client`.
### Issue Context
Even if TypeScript types no longer include `hanaClientDriver`, runtime configs (JS users, `as any`, env-based config readers) may still pass it. Silent ignore + fallback-to-require can cause confusing production failures.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-908]
### Suggested approach
- Detect `(this.options as any).hanaClientDriver` at runtime.
- Either:
- Throw a clear error: &amp;amp;amp;quot;`hanaClientDriver` was removed; use `driver` instead&amp;amp;amp;quot;, OR
- Temporarily support it with `const client = this.options.driver ?? (this.options as any).hanaClientDriver` and log a one-time deprecation warning.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

9. Undocumented hanaClientDriver removal 📘 Rule violation ✓ Correctness

Description

The PR removes previously-supported (even if deprecated) SAP driver options and fallback behavior
without any accompanying documentation updates. This can break existing configurations and leaves
users without guidance on required migration changes.

Code

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

10. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

    const poolOptions: any = {
        maxConnectedOrPooled:
            this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
            this.options.poolSize ??
            10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
        maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
    }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

11. hanaClientDriver fallback removed 🐞 Bug ⛯ Reliability

Description

loadDependencies() now only checks options.driver, so projects still using the deprecated
hanaClientDriver option will have their provided client ignored and may throw
DriverPackageNotInstalledError if @sap/hana-client isn’t installed.

Code

src/driver/sap/SapDriver.ts[889-908]
src/driver/sap/SapDataSourceOptions.ts[19-24]

+        const client = this.options.driver
       if (client) {
           this.client = client

Evidence

The driver injection path now exclusively uses options.driver and the SAP options interface no
longer includes hanaClientDriver, meaning older configuration will no longer inject a client. When
driver is absent, loadDependencies() falls back to loading @sap/hana-client, which fails if
the package isn’t installed.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Older configs using the deprecated `hanaClientDriver` will no longer inject their provided driver, and may unexpectedly attempt to require `@sap/hana-client`.
### Issue Context
Even if TypeScript types no longer include `hanaClientDriver`, runtime configs (JS users, `as any`, env-based config readers) may still pass it. Silent ignore + fallback-to-require can cause confusing production failures.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-908]
### Suggested approach
- Detect `(this.options as any).hanaClientDriver` at runtime.
- Either:
- Throw a clear error: &amp;quot;`hanaClientDriver` was removed; use `driver` instead&amp;quot;, OR
- Temporarily support it with `const client = this.options.driver ?? (this.options as any).hanaClientDriver` and log a one-time deprecation warning.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

12. Undocumented hanaClientDriver removal 📘 Rule violation ✓ Correctness

Description

The PR removes previously-supported (even if deprecated) SAP driver options and fallback behavior
without any accompanying documentation updates. This can break existing configurations and leaves
users without guidance on required migration changes.

Code

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

13. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

      const poolOptions: any = {
          maxConnectedOrPooled:
              this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
              this.options.poolSize ??
              10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
          maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
      }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

14. Undocumented hanaClientDriver removal 📘 Rule violation ✓ Correctness

Description

The PR removes previously-supported (even if deprecated) SAP driver options and fallback behavior
without any accompanying documentation updates. This can break existing configurations and leaves
users without guidance on required migration changes.

Code

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

15. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

      const poolOptions: any = {
          maxConnectedOrPooled:
              this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
              this.options.poolSize ??
              10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
          maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
      }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

16. hanaClientDriver fallback removed 🐞 Bug ⛯ Reliability

Description

loadDependencies() now only checks options.driver, so projects still using the deprecated
hanaClientDriver option will have their provided client ignored and may throw
DriverPackageNotInstalledError if @sap/hana-client isn’t installed.

Code

src/driver/sap/SapDriver.ts[889-908]
src/driver/sap/SapDataSourceOptions.ts[19-24]

+        const client = this.options.driver
      if (client) {
          this.client = client

Evidence

The driver injection path now exclusively uses options.driver and the SAP options interface no
longer includes hanaClientDriver, meaning older configuration will no longer inject a client. When
driver is absent, loadDependencies() falls back to loading @sap/hana-client, which fails if
the package isn’t installed.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Older configs using the deprecated `hanaClientDriver` will no longer inject their provided driver, and may unexpectedly attempt to require `@sap/hana-client`.
### Issue Context
Even if TypeScript types no longer include `hanaClientDriver`, runtime configs (JS users, `as any`, env-based config readers) may still pass it. Silent ignore + fallback-to-require can cause confusing production failures.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-908]
### Suggested approach
- Detect `(this.options as any).hanaClientDriver` at runtime.
- Either:
- Throw a clear error: &amp;amp;quot;`hanaClientDriver` was removed; use `driver` instead&amp;amp;quot;, OR
- Temporarily support it with `const client = this.options.driver ?? (this.options as any).hanaClientDriver` and log a one-time deprecation warning.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

17. Undocumented hanaClientDriver removal 📘 Rule violation ✓ Correctness

Description

The PR removes previously-supported (even if deprecated) SAP driver options and fallback behavior
without any accompanying documentation updates. This can break existing configurations and leaves
users without guidance on required migration changes.

Code

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

18. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

     const poolOptions: any = {
         maxConnectedOrPooled:
             this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
             this.options.poolSize ??
             10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
         maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
     }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

19. Custom driver breaks stream 🐞 Bug ✓ Correctness

Description

When a custom SAP client is supplied via options.driver, loadDependencies() returns early
without initializing streamClient, but SapQueryRunner.stream() unconditionally calls
this.driver.streamClient.createObjectStream(...), which can crash at runtime.

Code

src/driver/sap/SapDriver.ts[889-902]
src/driver/sap/SapQueryRunner.ts[371-382]

  protected loadDependencies(): void {
-        const client = this.options.driver ?? this.options.hanaClientDriver
+        const client = this.options.driver
      if (client) {
          this.client = client

Evidence

streamClient is only assigned in the PlatformTools.load() path (when options.driver is not
provided). However, streaming queries always assume driver.streamClient is defined and do not
guard against it being undefined.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Providing a custom SAP client via `options.driver` skips `streamClient` initialization, but streaming queries require it, leading to a runtime crash.
### Issue Context
This PR makes `driver` the only documented injection mechanism, so the `driver` path should be fully functional (including streaming) or fail with a clear message.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-902]
- src/driver/sap/SapQueryRunner.ts[371-382]
### Suggested approach
- In `loadDependencies()`, if `options.driver` is provided, still attempt to initialize `this.streamClient` (e.g., `PlatformTools.load(&amp;amp;quot;@sap/hana-client/extension/Stream&amp;amp;quot;)`) unless already set.
- Additionally, in `SapQueryRunner.stream()`, add a guard:
- if `!this.driver.streamClient`, throw a descriptive error telling users streaming requires the Stream extension / proper initialization.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

20. Custom driver breaks stream 🐞 Bug ✓ Correctness

Description

When a custom SAP client is supplied via options.driver, loadDependencies() returns early
without initializing streamClient, but SapQueryRunner.stream() unconditionally calls
this.driver.streamClient.createObjectStream(...), which can crash at runtime.

Code

src/driver/sap/SapDriver.ts[889-902]
src/driver/sap/SapQueryRunner.ts[371-382]

 protected loadDependencies(): void {
-        const client = this.options.driver ?? this.options.hanaClientDriver
+        const client = this.options.driver
     if (client) {
         this.client = client

Evidence

streamClient is only assigned in the PlatformTools.load() path (when options.driver is not
provided). However, streaming queries always assume driver.streamClient is defined and do not
guard against it being undefined.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Providing a custom SAP client via `options.driver` skips `streamClient` initialization, but streaming queries require it, leading to a runtime crash.
### Issue Context
This PR makes `driver` the only documented injection mechanism, so the `driver` path should be fully functional (including streaming) or fail with a clear message.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-902]
- src/driver/sap/SapQueryRunner.ts[371-382]
### Suggested approach
- In `loadDependencies()`, if `options.driver` is provided, still attempt to initialize `this.streamClient` (e.g., `PlatformTools.load(&amp;amp;amp;quot;@sap/hana-client/extension/Stream&amp;amp;amp;quot;)`) unless already set.
- Additionally, in `SapQueryRunner.stream()`, add a guard:
- if `!this.driver.streamClient`, throw a descriptive error telling users streaming requires the Stream extension / proper initialization.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

21. Custom driver breaks stream 🐞 Bug ✓ Correctness

Description

When a custom SAP client is supplied via options.driver, loadDependencies() returns early
without initializing streamClient, but SapQueryRunner.stream() unconditionally calls
this.driver.streamClient.createObjectStream(...), which can crash at runtime.

Code

src/driver/sap/SapDriver.ts[889-902]
src/driver/sap/SapQueryRunner.ts[371-382]

   protected loadDependencies(): void {
-        const client = this.options.driver ?? this.options.hanaClientDriver
+        const client = this.options.driver
       if (client) {
           this.client = client

Evidence

streamClient is only assigned in the PlatformTools.load() path (when options.driver is not
provided). However, streaming queries always assume driver.streamClient is defined and do not
guard against it being undefined.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Providing a custom SAP client via `options.driver` skips `streamClient` initialization, but streaming queries require it, leading to a runtime crash.
### Issue Context
This PR makes `driver` the only documented injection mechanism, so the `driver` path should be fully functional (including streaming) or fail with a clear message.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-902]
- src/driver/sap/SapQueryRunner.ts[371-382]
### Suggested approach
- In `loadDependencies()`, if `options.driver` is provided, still attempt to initialize `this.streamClient` (e.g., `PlatformTools.load(&amp;quot;@sap/hana-client/extension/Stream&amp;quot;)`) unless already set.
- Additionally, in `SapQueryRunner.stream()`, add a guard:
- if `!this.driver.streamClient`, throw a descriptive error telling users streaming requires the Stream extension / proper initialization.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

View more (1)

22. Custom driver breaks stream 🐞 Bug ✓ Correctness

Description

When a custom SAP client is supplied via options.driver, loadDependencies() returns early
without initializing streamClient, but SapQueryRunner.stream() unconditionally calls
this.driver.streamClient.createObjectStream(...), which can crash at runtime.

qodo-free-for-open-source-projects · 2026-03-04T20:16:57Z

Code Review by Qodo

🐞 Bugs (3) 📘 Rule violations (1) 📎 Requirement gaps (0)

1. hanaClientDriver fallback removed 🐞 Bug ⛯ Reliability ⭐ New

Description

loadDependencies() now only checks options.driver, so projects still using the deprecated
hanaClientDriver option will have their provided client ignored and may throw
DriverPackageNotInstalledError if @sap/hana-client isn’t installed.

Code

src/driver/sap/SapDriver.ts[889-908]
src/driver/sap/SapDataSourceOptions.ts[19-24]

+        const client = this.options.driver
        if (client) {
            this.client = client

Evidence

The driver injection path now exclusively uses options.driver and the SAP options interface no
longer includes hanaClientDriver, meaning older configuration will no longer inject a client. When
driver is absent, loadDependencies() falls back to loading @sap/hana-client, which fails if
the package isn’t installed.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Older configs using the deprecated `hanaClientDriver` will no longer inject their provided driver, and may unexpectedly attempt to require `@sap/hana-client`.

### Issue Context
Even if TypeScript types no longer include `hanaClientDriver`, runtime configs (JS users, `as any`, env-based config readers) may still pass it. Silent ignore + fallback-to-require can cause confusing production failures.

### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-908]

### Suggested approach
- Detect `(this.options as any).hanaClientDriver` at runtime.
- Either:
 - Throw a clear error: &quot;`hanaClientDriver` was removed; use `driver` instead&quot;, OR
 - Temporarily support it with `const client = this.options.driver ?? (this.options as any).hanaClientDriver` and log a one-time deprecation warning.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Undocumented hanaClientDriver removal 📘 Rule violation ✓ Correctness

Description

The PR removes previously-supported (even if deprecated) SAP driver options and fallback behavior
without any accompanying documentation updates. This can break existing configurations and leaves
users without guidance on required migration changes.

Code

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

3. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

       const poolOptions: any = {
           maxConnectedOrPooled:
               this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
               this.options.poolSize ??
               10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
           maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
       }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

4. Custom driver breaks stream 🐞 Bug ✓ Correctness ⭐ New

Description

When a custom SAP client is supplied via options.driver, loadDependencies() returns early
without initializing streamClient, but SapQueryRunner.stream() unconditionally calls
this.driver.streamClient.createObjectStream(...), which can crash at runtime.

Code

src/driver/sap/SapDriver.ts[889-902]
src/driver/sap/SapQueryRunner.ts[371-382]

    protected loadDependencies(): void {
-        const client = this.options.driver ?? this.options.hanaClientDriver
+        const client = this.options.driver
        if (client) {
            this.client = client

Evidence

streamClient is only assigned in the PlatformTools.load() path (when options.driver is not
provided). However, streaming queries always assume driver.streamClient is defined and do not
guard against it being undefined.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Providing a custom SAP client via `options.driver` skips `streamClient` initialization, but streaming queries require it, leading to a runtime crash.

### Issue Context
This PR makes `driver` the only documented injection mechanism, so the `driver` path should be fully functional (including streaming) or fail with a clear message.

### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-902]
- src/driver/sap/SapQueryRunner.ts[371-382]

### Suggested approach
- In `loadDependencies()`, if `options.driver` is provided, still attempt to initialize `this.streamClient` (e.g., `PlatformTools.load(&quot;@sap/hana-client/extension/Stream&quot;)`) unless already set.
- Additionally, in `SapQueryRunner.stream()`, add a guard:
 - if `!this.driver.streamClient`, throw a descriptive error telling users streaming requires the Stream extension / proper initialization.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

qodo-free-for-open-source-projects · 2026-03-04T20:19:44Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more

qodo-free-for-open-source-projects · 2026-03-04T20:32:28Z

Code Review by Qodo

🐞 Bugs (5) 📘 Rule violations (2) 📎 Requirement gaps (0)

1. Undocumented hanaClientDriver removal 📘 Rule violation ✓ Correctness

Description

The PR removes previously-supported (even if deprecated) SAP driver options and fallback behavior
without any accompanying documentation updates. This can break existing configurations and leaves
users without guidance on required migration changes.

Code

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

       const poolOptions: any = {
           maxConnectedOrPooled:
               this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
               this.options.poolSize ??
               10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
           maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
       }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

3. hanaClientDriver fallback removed 🐞 Bug ⛯ Reliability

Description

loadDependencies() now only checks options.driver, so projects still using the deprecated
hanaClientDriver option will have their provided client ignored and may throw
DriverPackageNotInstalledError if @sap/hana-client isn’t installed.

Code

src/driver/sap/SapDriver.ts[889-908]
src/driver/sap/SapDataSourceOptions.ts[19-24]

+        const client = this.options.driver
       if (client) {
           this.client = client

Evidence

The driver injection path now exclusively uses options.driver and the SAP options interface no
longer includes hanaClientDriver, meaning older configuration will no longer inject a client. When
driver is absent, loadDependencies() falls back to loading @sap/hana-client, which fails if
the package isn’t installed.

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Older configs using the deprecated `hanaClientDriver` will no longer inject their provided driver, and may unexpectedly attempt to require `@sap/hana-client`.
### Issue Context
Even if TypeScript types no longer include `hanaClientDriver`, runtime configs (JS users, `as any`, env-based config readers) may still pass it. Silent ignore + fallback-to-require can cause confusing production failures.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[889-908]
### Suggested approach
- Detect `(this.options as any).hanaClientDriver` at runtime.
- Either:
- Throw a clear error: &amp;quot;`hanaClientDriver` was removed; use `driver` instead&amp;quot;, OR
- Temporarily support it with `const client = this.options.driver ?? (this.options as any).hanaClientDriver` and log a one-time deprecation warning.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

View more (2)

4. Undocumented hanaClientDriver removal 📘 Rule violation ✓ Correctness

Description

The PR removes previously-supported (even if deprecated) SAP driver options and fallback behavior
without any accompanying documentation updates. This can break existing configurations and leaves
users without guidance on required migration changes.

Code

-    /**
-     * @deprecated Use {@link driver} instead.
-     */
-    readonly hanaClientDriver?: any

Evidence

Compliance requires documentation updates for user-facing API/usage changes. The diff removes
hanaClientDriver and multiple pool option properties, and also removes the runtime fallback that
previously accepted hanaClientDriver, but no docs changes are included and the PR checklist
indicates docs were not updated.

Rule 2: Docs updated for user-facing changes
src/driver/sap/SapDataSourceOptions.ts[25-28]
src/driver/sap/SapDriver.ts[887-890]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
This PR removes user-facing (deprecated but supported) SAP configuration options and fallback behavior, but does not update documentation to tell users how to migrate.
## Issue Context
`hanaClientDriver` and multiple pool options were removed from the public options interface and the driver no longer falls back to `hanaClientDriver` at runtime. Users need explicit migration guidance.
## Fix Focus Areas
- src/driver/sap/SapDataSourceOptions.ts[25-28]
- src/driver/sap/SapDriver.ts[887-890]】【”】【}}]}

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

5. Legacy pool config ignored 🐞 Bug ⛯ Reliability

Description

SapDriver no longer maps legacy pool option names (e.g., pool.max, pool.requestTimeout,
pool.idleTimeout) into the SAP HANA client pool options. Because ormconfig-loaded options are not
schema-validated, these legacy keys can still be present at runtime and will now be silently
ignored, changing pool limits/timeouts without any warning.

Code

      const poolOptions: any = {
          maxConnectedOrPooled:
              this.options.pool?.maxConnectedOrPooled ??
-                this.options.pool?.max ??
              this.options.poolSize ??
              10,
-            maxPooledIdleTime:
-                this.options.pool?.maxPooledIdleTime ??
-                (this.options.pool?.idleTimeout
-                    ? this.options.pool.idleTimeout / 1000
-                    : 30),
+            maxPooledIdleTime: this.options.pool?.maxPooledIdleTime ?? 30,
          maxWaitTimeoutIfPoolExhausted:
-                this.options.pool?.maxWaitTimeoutIfPoolExhausted ??
-                this.options.pool?.requestTimeout ??
-                0,
+                this.options.pool?.maxWaitTimeoutIfPoolExhausted ?? 0,
      }

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
SapDriver no longer reads deprecated SAP pool option keys, but runtime-loaded configs (ormconfig js/json/env) can still contain those keys. This results in silent misconfiguration (pool limits/timeouts not applied).
### Issue Context
TypeORM loads ormconfig objects without schema validation and does not remove unknown properties. If an app still uses legacy keys, SapDriver will ignore them and use defaults.
### Fix Focus Areas
- src/driver/sap/SapDriver.ts[279-295]
- src/connection/ConnectionOptionsReader.ts[94-205]
- src/connection/ConnectionOptionsReader.ts[210-276]
- docs/docs/guides/8-migration-v1.md[61-80]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

6. Custom driver breaks stream 🐞 Bug ✓ Correctness

Description

When a custom SAP client is supplied via options.driver, loadDependencies() returns early
without initializing streamClient, but SapQueryRunner.stream() unconditionally calls
this.driver.streamClient.createObjectStream(...), which can crash at runtime.

Code