Walkthrough

Added legacy mode support for Redis client compatibility by introducing runtime version detection (Redis 3.x via connect() presence check) and a shouldUsePromiseApi() method that determines API usage based on both Redis version and legacy mode status, replacing the previous isRedis5OrHigher() check across all cache operations.

Changes

Sequence Diagram

sequenceDiagram
    participant App
    participant RedisQueryResultCache
    participant PlatformTools
    participant RedisClient
    
    App->>RedisQueryResultCache: connect()
    RedisQueryResultCache->>PlatformTools: load("redis")
    PlatformTools-->>RedisQueryResultCache: createClient factory
    RedisQueryResultCache->>RedisClient: createClient()
    RedisQueryResultCache->>RedisQueryResultCache: detectRedisVersion()
    
    alt connect() method present
        RedisQueryResultCache->>RedisClient: client.connect()
        RedisClient-->>RedisQueryResultCache: connected
        RedisQueryResultCache->>RedisQueryResultCache: Set redisMajorVersion >= 4
    else connect() method absent
        RedisQueryResultCache->>RedisQueryResultCache: Set redisMajorVersion = 3
    end
    
    alt legacyMode enabled
        RedisQueryResultCache->>RedisQueryResultCache: Set isLegacyMode = true
    end
    
    App->>RedisQueryResultCache: getFromCache()
    RedisQueryResultCache->>RedisQueryResultCache: shouldUsePromiseApi()?
    
    alt shouldUsePromiseApi() returns true
        RedisQueryResultCache->>RedisClient: client.get() [Promise-based]
        RedisClient-->>RedisQueryResultCache: Promise<value>
    else shouldUsePromiseApi() returns false
        RedisQueryResultCache->>RedisClient: client.get(key, callback) [Callback-based]
        RedisClient-->>RedisQueryResultCache: value via callback
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

• New protected property and private method require understanding legacy mode semantics
• Version detection logic (including Redis 3.x check via connect() presence) needs verification against edge cases
• All Redis operation methods updated consistently, but each call site should be verified for correct shouldUsePromiseApi() usage
• New test cases introduce mock infrastructure that should be reviewed for completeness and accuracy

Possibly related issues

• getFromCache method throws error #11635: Directly addressed by this PR—fixes the "Cannot read properties of undefined (reading 'then')" error by detecting when Redis client uses callback-based API (Redis 3.x or legacy mode) and avoiding Promise-based operations in those cases.
• Bug in detectRedisVersion #11749: Related through Redis v3 detection logic—the added connect() presence guard addresses v3 detection that was previously misidentified.

Possibly related PRs

• feat(11528): add Redis 5.x support with backward compatibility wite peer dependency to allow #11585: Both PRs modify RedisQueryResultCache to add runtime Redis version detection and branch between callback-based and Promise-based APIs, representing parallel or related work on the same compatibility problem.

Suggested reviewers

• gioboa
• alumni

Poem

🐰 A Redis tale of modes and versions past,
Legacy and promise, compatible at last!
Three, four, and five—our fuzzy friend detects,
Callbacks bloom where legacy connects! ✨
TypeORM hops on, no more errors—hooray! 🎉

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Have you seen #11767? Can you elaborate why do you think your solution is better then what's presented in #11767?

@pkuczynski no I didn't see that! my approach is a continuation of the first approach, but probably the one in #11767 is more robust. the only possible downside is This operation only supports on node platform. but for me anyone works. thanks

@ibrahimmenem thank you for your work on this.

I think we are going to go with the approach in #11767 since it sets us up to better handle different redis versions going forward, but let's leave this open until we have a working fix merged in.