chore: disable eslint errors for chai assertions #11700
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
|
If we plan to merge more than a few PRs into |
|
I think we can merge it straight to master 👀 |
|
And then sync I'm more tempted to only do the strictly necessary for 0.3, I'd rather not put much effort into something that will be obsolete by the end of the year :) |
Description of change
Currently we set
@typescript-eslint/no-unused-expressionsto warn, which highlights a lot of errors in ourchaiassertions. When using both styles of assertion ("expect" and "should"),chaihas side-effects which eslint is trying to prevent with this rule.I disabled this rule for the assertions in the tests via
eslint-plugin-chai-friendly, and set it to error in the rest of the code. I also corrected the remaining errors.Before: 10807 warnings
After: 9207 warnings
Pull-Request Checklist
nextbranchFixes #00000