feat: postgres jsonpath column type #10457
Conversation
|
looks like tests are failing |
| }, | ||
| ] | ||
| document.date = new Date() | ||
| document.path = "$.weight" |
|
|
||
| @Column({ type: "jsonpath" }) | ||
| path: string | ||
|
|
| post.uuid = "0e37df36-f698-11e6-8dd4-cb9ced3df976" | ||
| post.json = { id: 1, name: "Post" } | ||
| post.jsonb = { id: 1, name: "Post" } | ||
| post.jsonpath = "$.name" |
There was a problem hiding this comment.
please add a test checks below like we did for another column types
There was a problem hiding this comment.
added assertions for jsonpath
|
@pleerock the oracle test failed due to a timeout, could you please rerun it? |
gioboa
left a comment
There was a problem hiding this comment.
Hi, thanks for your help @nialexsan
is this PR still valid? can you fix the test and align the PR with the master branch please?
| import { expect } from "chai" | ||
| import { Example } from "./entity/example" | ||
|
|
||
| // values from https://github.com/obartunov/sqljsondoc/blob/master/jsonpath.md#jsonpath-in-postgresql |
There was a problem hiding this comment.
I would rather add link to the postgres documentation here, and only mention source for the current values in the comment for PR.
Valid links would be:
| beforeEach(() => reloadTestingDatabases(connections)) | ||
| after(() => closeTestingConnections(connections)) | ||
|
|
||
| it("should insert and retrieve jsonpath values as strings", () => |
There was a problem hiding this comment.
I think all those tests should be implemented in test/functional/database-schema/column-types/postgres/column-types-postgres.ts. This is not a bug we are dealing with here, rather new feature. It would be super hard to find those tests later when the burried in issue-10456.ts
Description of change
Fixes #10456
Adds
jsonpathcolumn type for PostgresPull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000