Skip to content

Allow explicitly named constraints in SAP HANA #11348

@alumni

Description

@alumni

Feature Description

primaryKeyConstraintName / foreignKeyConstraintName / etc. should be respected when the DB is SAP HANA.

The Solution

Extend the work in #8900 to the SAP HANA driver. SapQueryRunner needs to be adjusted to use the constraint names. The tests disabled in #11347 should be enabled.

Considered Alternatives

n/a

Additional Context

This will also allow the tests written in #8900 to pass for the SAP driver.

This missing feature was identified while setting up SAP HANA tests in #11347.

Relevant Database Driver(s)

  • aurora-mysql
  • aurora-postgres
  • better-sqlite3
  • cockroachdb
  • cordova
  • expo
  • mongodb
  • mysql
  • nativescript
  • oracle
  • postgres
  • react-native
  • sap
  • spanner
  • sqlite
  • sqlite-abstract
  • sqljs
  • sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, and I know how to start.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions