Do not pluralize singular failure.#186
Closed
dubinsky wants to merge 1 commit intotypelevel:mainfrom
dubinsky:do-not-pluralize-singular-failure
Closed
Do not pluralize singular failure.#186dubinsky wants to merge 1 commit intotypelevel:mainfrom dubinsky:do-not-pluralize-singular-failure
dubinsky wants to merge 1 commit intotypelevel:mainfrom
dubinsky:do-not-pluralize-singular-failure
Conversation
Currently, single assertion failure gets packaged into `Result.Failures` (plural), when it should be just `Result.Failure` (singular).
This was referenced Aug 14, 2025
Collaborator
|
I'm not certain this is the direction we should ultimately take : I don't remember exactly what was the reasoning behind having the two classes and we need to dig deeper to potentially change the modelling altogether |
Contributor
Author
I wish you success! |
Contributor
|
Thanks! This has been incorporated in #192. |
Contributor
Author
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, single assertion failure gets packaged into
Result.Failures(plural), when it should be justResult.Failure(singular).