Set up a proper cross build by vasilmkd · Pull Request #860 · typelevel/scalacheck

vasilmkd · 2021-12-07T23:00:48Z

Fixes #625.

Edited:

This snapshot seems to be working fine on all platforms:

"io.vasilev" %%% "scalacheck" % "1.15-6862df0"

Help for reviewers, list of changes:

Created a core directory where all the code is found (similar to other Typelevel libraries).
Set up a proper cross build in core (one project with three platforms and platform specific managed sources instead of three projects with unmanaged sources)
jvm became the jvm cross build under core/jvm
js became the js cross build under core/js
native became the native cross build under core/native
src became the shared source code for all platforms under core/shared/src
I changed the scala-2.13- and scala-2.13+ unmanaged directories to use the "official" scala-2.12, scala-2.13 and scala-3 Scala versions specific directories supported by the crossproject plugins (the sources under scala-3 can be seen as new files in the diff)
Removed as much cruft as possible from the build.sbt file
Removed the release.sh script because sbt-spiewak-sonatype contains sbt-sonatype which can be used for releases (already used it to publish a snapshot and tested the release)
Tweaked things in tools/travis-script.sh to match the new subprojects (coreJVM, coreJS, coreNative)

There are build warnings which I plan to address in a follow-up PR, to keep this diff as small as possible.

vasilmkd · 2021-12-07T23:46:31Z

The Scala.js tests also don't seem to run on Scala 3.1.0 and Scala 3.0.2 with the following warning:

[warn] multiple main classes detected: run 'show discoveredMainClasses' to see the list

but this is the output:

sbt:scalacheck> show coreJS/discoveredMainClasses
[info] *

Edit: resolved.

armanbilge · 2021-12-07T23:54:22Z

What's the output of show coreJS/Test/discoveredMainClasses?

vasilmkd · 2021-12-07T23:55:55Z

Good point, I've been staring at the screen too long:

sbt:scalacheck> show coreJS/Test/discoveredMainClasses
[info] * org.scalacheck.NoPropertyNestingSpecification
[info] * org.scalacheck.PropSpecification
[info] * org.scalacheck.PropsObject
[info] * org.scalacheck.ShrinkSpecification
[info] * org.scalacheck.StatsSpecification
[info] * org.scalacheck.examples.Examples
[info] * org.scalacheck.examples.MathSpec
[info] * org.scalacheck.util.PrettySpecification
[info] * scala.StringSpecification
[success] Total time: 0 s, completed Dec 8, 2021, 12:55:16 AM

Edit: resolved.

armanbilge · 2021-12-07T23:56:57Z

You can set Test / mainClass := Some(...)

vasilmkd · 2021-12-08T00:00:18Z

It doesn't seem to do anything. :/

Edit: resolved.

vasilmkd · 2021-12-08T00:01:24Z

Also, the output of coreJS/Test/discoveredMainClasses is exactly the same on Scala 2.13 and Scala 3 and it works without issues on Scala 2.13 (most likely Scala 2.12 too).

Edit: resolved.

armanbilge · 2021-12-08T00:02:44Z

Maybe has something to do with these sbt test frameworks things? I always thought tests used a different mechanism mutually exclusive to main classes.

vasilmkd · 2021-12-08T00:27:31Z

The "multiple main classes" warning is visible in CI before this PR, so that's most likely a red herring.

Here's what happens when running the compiled JS code manually.

vasil@vasil-mac scalacheck-test-fastopt % node main.js
/Users/vasil/Code/scalacheck/core/js/target/scala-3.0.2/scalacheck-test-fastopt/main.js:12344
  scalajsCom.init(((arg1$2) => {
  ^

ReferenceError: scalajsCom is not defined
    at new $c_Lorg_scalajs_testing_bridge_JSRPC$ (/Users/vasil/Code/scalacheck/core/js/target/scala-3.0.2/scalacheck-test-fastopt/main.js:12344:3)
    at $m_Lorg_scalajs_testing_bridge_JSRPC$ (/Users/vasil/Code/scalacheck/core/js/target/scala-3.0.2/scalacheck-test-fastopt/main.js:12371:45)
    at new $c_Lorg_scalajs_testing_bridge_TestAdapterBridge$ (/Users/vasil/Code/scalacheck/core/js/target/scala-3.0.2/scalacheck-test-fastopt/main.js:5848:155)
    at $m_Lorg_scalajs_testing_bridge_TestAdapterBridge$ (/Users/vasil/Code/scalacheck/core/js/target/scala-3.0.2/scalacheck-test-fastopt/main.js:5872:57)
    at $c_Lorg_scalajs_testing_bridge_Bridge$.start__V (/Users/vasil/Code/scalacheck/core/js/target/scala-3.0.2/scalacheck-test-fastopt/main.js:4562:5)
    at $s_Lorg_scalajs_testing_bridge_Bridge__start__V (/Users/vasil/Code/scalacheck/core/js/target/scala-3.0.2/scalacheck-test-fastopt/main.js:4537:44)
    at Object.<anonymous> (/Users/vasil/Code/scalacheck/core/js/target/scala-3.0.2/scalacheck-test-fastopt/main.js:39538:1)
    at Object.<anonymous> (/Users/vasil/Code/scalacheck/core/js/target/scala-3.0.2/scalacheck-test-fastopt/main.js:39539:4)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)

Edit: resolved.

armanbilge · 2021-12-08T00:29:48Z

That's normal AFAIK. Any project if you try to run the generated test js outside of the sbt test context you get that Scala com error.

vasilmkd · 2021-12-08T01:43:31Z

Everything might have been related to improper scalacOptions on Scala 3. I should have trusted sbt-spiewak and not tried to restore the old scalacOptions. I was aiming for a smaller diff.

vasilmkd · 2021-12-08T09:34:32Z

This snapshot seems to be working fine on all platforms:

"io.vasilev" %%% "scalacheck" % "1.15-6862df0"

pmeheut · 2021-12-20T17:24:44Z

I have the same problem: crossProject named nscalaJavaTime with crossType(CrossType.Pure).
The tests run with the JVM. But when I run them with Scala.js, i.e.:
nscalaJavaTimeJS / test
All I get is:

info] compiling 3 Scala sources to /Users/pascal/eclipse/workspace/nscala-java-time/.js/target/scala-2.13/test-classes ...
[info] done compiling
[warn] multiple main classes detected: run 'show discoveredMainClasses' to see the list
[info] Fast optimizing <dir>/nscala-java-time/.js/target/scala-2.13/nscala-java-time-test-fastopt
[success] Total time: 4 s, completed <date>

There are no main anywhere in the project and I tried with several versions including "io.vasilev" %% "scalacheck" % "1.15-6862df0"

vasilmkd · 2021-12-20T17:38:30Z

That turned out to be a problem with Scala 3 scalacOptions, I don't get the issue anymore in this PR. Hope it helps.

pmeheut · 2021-12-20T17:51:49Z

Even with no scalacOptions, I get the problem. I'll try to build a simple test case and let you know if I can reproduce it easily.

armanbilge · 2021-12-20T18:17:21Z

@pmeheut what is the output of running show coreJS/Test/discoveredMainClasses in sbt? Replacing coreJS with your JS module name.

pmeheut · 2021-12-20T18:19:43Z

�show nscalaJavaTimeJS / Test / discoveredMainClasses
[info] * com.github.nscala_java_time.time.BasicFunctionalitySpec
[info] * com.github.nscala_java_time.time.OrderingSpec
[info] * com.github.nscala_java_time.time.RichStringSpec

i.e. the 3 Spec files in the project.

armanbilge · 2021-12-20T18:26:12Z

@pmeheut interesting, do you have mainModuleInitializer := true somewhere in your settings?

pmeheut · 2021-12-20T18:32:04Z

No mainModuleInitializer in the project.

armanbilge · 2021-12-20T18:39:52Z

@pmeheut another random idea, try setting:

testFrameworks += new TestFramework("org.scalacheck.ScalaCheckFramework")

Otherwise, out of ideas, sorry 😕

pmeheut · 2021-12-20T18:46:56Z

It changes nothing. Thanks for all the quick answers. I'll investigate on my own tomorrow.

pmeheut · 2021-12-20T21:11:18Z

I took a very simple project, https://github.com/scala-js/scalajs-cross-compile-example, added scalacheck and tests in the js and jvm src/test/scala directories.

When I run fooJVM / testI get:

failing seed for Main.Main test failed is TOFNUsU1lFvvZvKowQTTn642grCKU0yenGFOJkAYEKD=
[info] + Main.Main test succeeded: OK, proved property.
[info] ! Main.Main test failed: Falsified after 0 passed tests.
[info] Failed: Total 2, Failed 1, Errors 0, Passed 1
[error] Failed tests:
[error] 	example.MainSpec
[error] (fooJVM / Test / test) sbt.TestsFailedException: Tests unsuccessful

as expected.

When I run fooJS / test, I get only:

[success] Total time: 3 s, completed 20 déc. 2021 à 22:06:17

You can get the project here if you want to try it:
sample scalajs/scalacheck project

armanbilge · 2022-01-22T18:27:48Z

I do hope we'll move forward with this. Now that Vasil's done the hard work it should be an easy jump to sbt-typelevel.

vasilmkd · 2022-01-22T18:28:45Z

I'm planning to refresh this PR very soon.

armanbilge · 2022-01-22T18:32:48Z

Btw, is scalacheck using PVP versioning? Actually sbt-typelevel doesn't really support that.

pmeheut · 2022-01-22T18:42:44Z

Still on it but I had to work for my daily job.

…

Le 22 janv. 2022 à 19:33, Arman Bilge ***@***.***> a écrit : Btw, is scalacheck using PVP versioning? Actually sbt-typelevel doesn't really support that. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

vasilmkd · 2022-03-07T06:04:43Z

Superseded by #875. Thanks @armanbilge for taking care of this big change and for sbt-typelevel.

vasilmkd force-pushed the cross branch from 4f64a81 to bb4c884 Compare December 7, 2021 23:08

vasilmkd marked this pull request as ready for review December 8, 2021 09:34

vasilmkd added 16 commits December 8, 2021 23:54

Compiles on Scala 2.13

f7dcaad

Cross compile with Scala 2.12

e520d75

Cross compile with Scala 3 and Scala 3.1

43f2d48

Compile benchmarks

b997bac

Add release settings

ef179d9

Final release settings tweaks

e58b422

Restore the CI

b6a26ba

Remove the release script

c03862d

Rename the platforms to match the subprojects

d13823b

Fix header issues in benchmarks directory

df9b1ec

Add a license just in case

0a5bd78

Don't forget generated sources

899e307

Use the sbt-spiewak scalacOptions

63c294e

Disable fatal warnings

d44a1af

The comment confused me so I removed that setting

2992669

Vasil, don't hijack ScalaCheck

7592e57

vasilmkd force-pushed the cross branch from 97a3e23 to 7592e57 Compare December 8, 2021 22:54

vasilmkd mentioned this pull request Jan 5, 2022

support scala-native Scala 3 build #868

Closed

armanbilge mentioned this pull request Mar 1, 2022

3rd party artifacts are indexed together with official library versions - possible security breach scalacenter/scaladex#927

Open

rossabaker mentioned this pull request Mar 7, 2022

Migrate to sbt-typelevel #875

Merged

vasilmkd closed this Mar 7, 2022

Uh oh!

Conversation

vasilmkd commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vasilmkd commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

armanbilge commented Dec 7, 2021

Uh oh!

vasilmkd commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

armanbilge commented Dec 7, 2021

Uh oh!

vasilmkd commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vasilmkd commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

armanbilge commented Dec 8, 2021

Uh oh!

vasilmkd commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

armanbilge commented Dec 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vasilmkd commented Dec 8, 2021

Uh oh!

vasilmkd commented Dec 8, 2021

Uh oh!

pmeheut commented Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vasilmkd commented Dec 20, 2021

Uh oh!

pmeheut commented Dec 20, 2021

Uh oh!

armanbilge commented Dec 20, 2021

Uh oh!

pmeheut commented Dec 20, 2021

Uh oh!

armanbilge commented Dec 20, 2021

Uh oh!

pmeheut commented Dec 20, 2021

Uh oh!

armanbilge commented Dec 20, 2021

Uh oh!

pmeheut commented Dec 20, 2021

Uh oh!

pmeheut commented Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

armanbilge commented Jan 22, 2022

Uh oh!

vasilmkd commented Jan 22, 2022

Uh oh!

armanbilge commented Jan 22, 2022

Uh oh!

pmeheut commented Jan 22, 2022 via email

Uh oh!

vasilmkd commented Mar 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vasilmkd commented Dec 7, 2021 •

edited

Loading

vasilmkd commented Dec 7, 2021 •

edited

Loading

vasilmkd commented Dec 7, 2021 •

edited

Loading

vasilmkd commented Dec 8, 2021 •

edited

Loading

vasilmkd commented Dec 8, 2021 •

edited

Loading

vasilmkd commented Dec 8, 2021 •

edited

Loading

armanbilge commented Dec 8, 2021 •

edited

Loading

pmeheut commented Dec 20, 2021 •

edited

Loading

pmeheut commented Dec 20, 2021 •

edited

Loading