removes the "compile-time" config in favor of "provided"#655
Merged
armanbilge merged 2 commits intotypelevel:mainfrom Oct 31, 2023
Merged
removes the "compile-time" config in favor of "provided"#655armanbilge merged 2 commits intotypelevel:mainfrom
armanbilge merged 2 commits intotypelevel:mainfrom
Conversation
armanbilge
reviewed
Oct 27, 2023
Comment on lines
+32
to
+33
| lazy val CompileTime: Configuration = config("compile-time").hide | ||
| @deprecated("use `Provided` instead", "0.6.1") | ||
| lazy val CompileTime: Configuration = Provided |
Member
There was a problem hiding this comment.
Since we're deprecating it anyway I wonder if we should leave the old definition. Also I wonder if anyone could have been using it like "compile-time" instead of CompileTime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May resolve #654