Windows-compatible programmatic compilations#180
Merged
chriskrycho merged 1 commit intotyped-ember:programmatic-compilationfrom Apr 9, 2018
tansongyang:programmatic-compilation
Merged
Windows-compatible programmatic compilations#180chriskrycho merged 1 commit intotyped-ember:programmatic-compilationfrom tansongyang:programmatic-compilation
chriskrycho merged 1 commit intotyped-ember:programmatic-compilationfrom
tansongyang:programmatic-compilation
Conversation
Previously, on Windows, `broccoli` would fail with this error:
EPERM: operation not permitted, symlink ...
This appeared to only happen the first time it attempted to create a
symlink from `tmp/broccoli_merge_trees-output_path-{some_hash}.tmp` to
`tmp/funnel-input_base_path-{some_other_hash}.tmp`.
We don't know the cause, but the error goes away when we use `chokidar`.
Member
|
Heh, that specific failure looks like a problem with the type definitions, not with your work! (More on Monday.) |
Contributor
|
I ran into some mega annoying install issues due to chokidar's need for native dependencies, and This library was explicitly avoided in ember-cli, due to reasons stated in the following issue Also react-native avoided adding it for similar reasons TL;DR - we may want to work our way back to using watchman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, this contains just the changes needed to successfully compile on Windows. See commit comments for details on why I switched from
sanetochokidar.I tried to fix
ts:precompile, but I wasn't entirely sure what it was supposed to do. Runningember ts:precompileonmasterright now produces this error:So, I'll need some help fixing
ts:precompile.TLDR:
ts:precompile.reportDiagnosticandreportWatchStatusto do.