Skip to content

Windows-compatible programmatic compilations#180

Merged
chriskrycho merged 1 commit intotyped-ember:programmatic-compilationfrom
tansongyang:programmatic-compilation
Apr 9, 2018
Merged

Windows-compatible programmatic compilations#180
chriskrycho merged 1 commit intotyped-ember:programmatic-compilationfrom
tansongyang:programmatic-compilation

Conversation

@tansongyang
Copy link
Copy Markdown
Contributor

So far, this contains just the changes needed to successfully compile on Windows. See commit comments for details on why I switched from sane to chokidar.

I tried to fix ts:precompile, but I wasn't entirely sure what it was supposed to do. Running ember ts:precompile on master right now produces this error:

Error: Command failed: tsc --outDir Me\AppData\Local\Temp/e-c-ts-precompile-23496 --rootDir Me\ember-cli-typescript --allowJs false --noEmit false --declaration --sourceMap false --inlineSourceMap false --inlineSources false

tests/dummy/app/helpers/typed-help.ts(7,1): error TS4082: Default export of the module has or is using private name 'Ember.Helper'.

So, I'll need some help fixing ts:precompile.

TLDR:

  • Fix ts:precompile.
  • Clean up. In particular, we should decide what we want reportDiagnostic and reportWatchStatus to do.

Previously, on Windows, `broccoli` would fail with this error:

    EPERM: operation not permitted, symlink ...

This appeared to only happen the first time it attempted to create a
symlink from `tmp/broccoli_merge_trees-output_path-{some_hash}.tmp` to
`tmp/funnel-input_base_path-{some_other_hash}.tmp`.

We don't know the cause, but the error goes away when we use `chokidar`.
@chriskrycho
Copy link
Copy Markdown
Member

Heh, that specific failure looks like a problem with the type definitions, not with your work! (More on Monday.)

@chriskrycho chriskrycho merged commit 9f2f49b into typed-ember:programmatic-compilation Apr 9, 2018
@tansongyang tansongyang deleted the programmatic-compilation branch April 9, 2018 15:47
@mike-north
Copy link
Copy Markdown
Contributor

I ran into some mega annoying install issues due to chokidar's need for native dependencies, and

This library was explicitly avoided in ember-cli, due to reasons stated in the following issue
ember-cli/ember-cli#4503

Also react-native avoided adding it for similar reasons
facebook/react-native#628

TL;DR - we may want to work our way back to using watchman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants