Conversation
|
❤️ I'll try to take a gander if you want… but probably after EmberConf. |
| "ember-cli-release": "^0.2.9", | ||
| "ember-cli-shims": "^1.2.0", | ||
| "ember-cli-sri": "^2.1.0", | ||
| "ember-cli-typescript": "^1.1.6", |
There was a problem hiding this comment.
I believe npm would error on this (same name as package) ?
There was a problem hiding this comment.
I haven't checked on publishing, but certainly none of the local operations complain. You'd never be able to publish any package which wanted to use itself otherwise.
There was a problem hiding this comment.
Yes, for example typescript is written in typescript and thus has itself as a dependency. Inception!
There was a problem hiding this comment.
@dwickern not really, they do not add it in package.json, I believe they use a last known good version here https://github.com/Microsoft/TypeScript/tree/master/lib
And yes that's what I meant @chriskrycho, it won't publish if same name is inside dependencies.
There was a problem hiding this comment.
There was a problem hiding this comment.
Okay this will not cause any problem. Releasing will work too as it is in devDependencies. I just checked with a dummy package :)
Sorry for troubling :D
| "test": "ember try:each", | ||
| "nodetest": "mocha node-tests --recursive" | ||
| "nodetest": "mocha node-tests --recursive", | ||
| "prepublishOnly": "ember ts:precompile", |
There was a problem hiding this comment.
Hadn't even occurred to me that this would work for our purposes here—nice! 😄
|
What does development/testing of e-c-ts itself look like with this setup? Would we use |
|
Personally I've developed using I had to disable |
Yep, that makes sense. It would be great once we've got this all figured out if we could make it as easy as possible for other addons to use TS in their node-side code. Until MU lands, there would be some slight weirdness with declaration files (e.g. does |
|
The root |
|
@dwickern the problem is that it's overloaded: it also ends up being the root import for when you import something from an addon. Maybe we should recommend doing |
|
Isn't that the build for the dummy app? 🙈 |
This is a first pass at converting the addon to typescript. I've converted the addon code, blueprints and supporting code. I haven't touched tests yet.
Most of the effort so far was spent writing type definitions for various ember-cli/broccoli dependencies.