chore: Use produced / consumed semantic from Pallas #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhrpr
reviewed
Sep 18, 2022
Comment on lines
+141
to
142
| for (idx, output) in tx.produces().iter().enumerate() { | ||
| let key: IVec = format!("{}#{}", tx.hash(), idx).as_bytes().into(); |
Contributor
There was a problem hiding this comment.
This is a bug: if the Tx is invalid then a UTxO using the collateral return TxOut is created but the TxIn for the UTxO is defined as having the index |txouts|, that is the collateral return UTxO is given the next available index after the number of txouts contained in the transaction, but the current implementation gives it the index 0. This affects the UTxO reducer as well.
Will PR fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.