ci,build: Add flake8, black, isort (and wire into CI)#42
Merged
twmr merged 12 commits intotwmr:masterfrom Sep 4, 2022
Merged
Conversation
ERROR: pyproject.toml file found. To use a PEP 517 build-backend you are required to configure tox to use an isolated_build: https://tox.readthedocs.io/en/latest/example/package.html
4322934 to
0c10360
Compare
./tests/test_text_files.py:210:1: W293 blank line contains whitespace ./tests/test_text_files.py:227:1: W293 blank line contains whitespace
0c10360 to
4f81f62
Compare
4f81f62 to
6b9c2de
Compare
Owner
|
Thx a lot for that! I wanted to add a black/isort CI setup long ago! |
Contributor
Author
|
@Thisch This is a nice one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #41 (pyproject.toml)
Changes
Add
[lint](pip install -e '.[lint]') for flake8, isort, blackThis assures that normal packaging isn't bloated, but the dependencies can still be installed by developers
Add 3 lint tools
Lint configurations
The configurations are stock, except isort and flake8 both have
blackprofiles (docs)CI