Skip to content

fix: check error before deferring #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xemdo merged 2 commits into from
Oct 30, 2023
Merged

fix: check error before deferring #285

Xemdo merged 2 commits into from
Oct 30, 2023

Conversation

@SputNikPlop
Copy link
Contributor

@SputNikPlop SputNikPlop commented Oct 18, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

The error is not handled the proper way as it is supposed to in Go

Description of Changes:

  • Changed to check error before deferring

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo merged commit 1b3a1c4 into twitchdev:main Oct 30, 2023
@SputNikPlop SputNikPlop deleted the deferring branch October 30, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xemdo Xemdo Xemdo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SputNikPlop @Xemdo