Skip to content

Conversation

@frifugio
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

As explained in the official documentation for the GET Drops Entitlements API, fulfillment_status is one of the possible query parameter that the API is accepting.
Until now, this parameter was ignored in the mock-api. This PR aims to fix this, so now the mock-api supports filtering by fulfillment_status.

Description of Changes:

  • Read the "fulfillment_status" optional query parameter from the URL
  • Use this new field as a value to the DropsEntitlement object used for the DB query

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo self-requested a review July 12, 2023 18:52
@Xemdo Xemdo merged commit 5a867de into twitchdev:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants