10269: Annotate readBody as per the docstring#1668
Merged
twm merged 6 commits intotwisted:trunkfrom Jan 17, 2022
Merged
Conversation
readBody as per the docstringreadBody as per the docstring
Contributor
Author
|
pypy-3.7-alldeps-nocov-posix is failing. Not sure why? pypy-3.7-alldeps-withcov-posix is succeeding so I wonder if this might be some CI flakiness? (Given that my changes are just type hints, and that there aren't any extra imports, I wouldn't expect there to be any behaviour changes at runtime.) |
7 tasks
twm
approved these changes
Dec 27, 2021
Member
twm
left a comment
There was a problem hiding this comment.
Looks great, thank you! The build failure is surely flakiness; I'll poke at it a bit.
Member
|
@twm @DMRobertson Hopefully the build flakiness was https://twistedmatrix.com/trac/ticket/10291 and it's fixed now? |
Member
|
Thank you for fixing that @glyph! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Quick drive-by contribution. The docstring already describes the input and output types for this function. I'd like to make those part of the annotations.
Contributor Checklist:
tox -e lintto format my patch to meet the Twisted Coding Standard#character).reviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.The first line is automatically generated by GitHub based on PR ID and branch name.
The other lines generated by GitHub should be replaced.