Specify class returning itself in Logger.__get__.#1541
Merged
wsanchez merged 2 commits intotwisted:trunkfrom Mar 8, 2021
Merged
Specify class returning itself in Logger.__get__.#1541wsanchez merged 2 commits intotwisted:trunkfrom
Logger.__get__.#1541wsanchez merged 2 commits intotwisted:trunkfrom
Conversation
5882fe4 to
070c0e5
Compare
graingert
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
This pull request aims to fix a type error reported by
mypywhen checking classes with a class attribute instantiatingtwisted.logger.Logger.Contributor Checklist:
tox -e lintto format my patch to meet the Twisted Coding Standardreviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.