Merged
Conversation
This was referenced Aug 18, 2020
glyph
previously requested changes
Aug 21, 2020
Member
glyph
left a comment
There was a problem hiding this comment.
Thanks os much for contributing this ryanc!
Would you mind adding a little bit of test coverage for this just to ensure it doesn't regress? Something very simple like twisted.web.test.test_agent._RedirectAgentTestsMixin.test_redirect301 does should do.
Contributor
Author
|
No problem @glyph - happy to contribute! I've duplicated the 301 redirect test. Will wait for the CI tests to pass then amend the ticket on Trac. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for
308 Permanent Redirectson theRedirectAgent.Contributor Checklist:
reviewto the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.