Conversation
- email.message.Message is more accurate now about get_payload's union - globaltrace attribute is now exposed
|
please review |
|
@itamarst in particular |
|
hell yeah, CI passed on the first try |
adiroiban
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing trunk.
Thanks for the separate ticket.
I have updated the title of the PR to include the link to ticket number.
The macos tests might have passed now, but in the past they were failing quite often on first times, and sometimes even on second try :(
I still don't know how to fix them.
Yeah I really don't know what's going on there. I no longer know what the bug is in the reactor itself, which seems like it should work to me now. And I never see these failures locally. I really wonder if it's something that github has done to their builders. |
Scope and purpose
Fixes #12113
Add a few words about why this PR is needed and what is its scope.
If the associate ticket(s) fully explain the need you can just refer to it/them.
Add any comments about trade-offs (if any) made in this PR and the reasoning behind them.
Add mentions of things that are not covered here and are planed to be done in separate PRs.
Contributor Checklist:
This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.
Below is a non-exhaustive list (as a reminder):
please review.Our bot will trigger the review process, by applying the pending review label
and requesting a review from the Twisted dev team.