#11848 Remove the usage of cgi.parse_multipart and replace with email module.#12058
#11848 Remove the usage of cgi.parse_multipart and replace with email module.#12058
Conversation
| """ | ||
| Like C{cgi.parse_qs}, but with support for parsing byte strings on Python 3. | ||
|
|
||
| This was created to help with Python 2 to Python 3 migration. |
There was a problem hiding this comment.
I have added this comment to trigger a conversation.
Maybe this function should be deprecated (in a separate PR), and just use stdlib.
There was a problem hiding this comment.
Could we just replace it with a deprecated alias of parse_qs, or does its behavior differ significantly?
In any case yeah eventually deprecating it sounds good.
|
I did a quick fix. The tests pass... but I am not sure this is the right fix. needs-review |
glyph
left a comment
There was a problem hiding this comment.
really glad to see the process working and advance builds with alphas causing us to catch up with deprecations
| """ | ||
| Like C{cgi.parse_qs}, but with support for parsing byte strings on Python 3. | ||
|
|
||
| This was created to help with Python 2 to Python 3 migration. |
There was a problem hiding this comment.
Could we just replace it with a deprecated alias of parse_qs, or does its behavior differ significantly?
In any case yeah eventually deprecating it sounds good.
Scope and purpose
Fixes #11848
This should be the last usage of
cgimodule in Twisted.It uses the stdlib
emailmodule.I with with stdlib to reduce the need for an extra dependency or reinvent the wheel.
I think that if there are any issued with stdlib, they should be fixed upstream.
See twisted/treq#355 for other options.