Whitespace between releases can be configured in the template.#553
Merged
adiroiban merged 6 commits intotwisted:trunkfrom Oct 21, 2023
Merged
Whitespace between releases can be configured in the template.#553adiroiban merged 6 commits intotwisted:trunkfrom
adiroiban merged 6 commits intotwisted:trunkfrom
Conversation
adiroiban
approved these changes
Oct 19, 2023
Member
adiroiban
left a comment
There was a problem hiding this comment.
Thanks for the changes.
Changes looks good.
I left a few minor comments.
A note for another PR
I now see that we don't run towncrier draft as part of the CI process.
I guess that it could help to have it executed and the output sent as part of the job output...
similar to the output that we have for build and coverage
https://github.com/twisted/towncrier/actions/runs/6580860357#summar
7 tasks
Contributor
Author
|
@adiroiban this is ready for review, thanks! |
It used to be baked into the rendering code.
for more information, see https://pre-commit.ci
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
443b0a3 to
07ca4f1
Compare
Member
|
Thanks for the extra comment. Looks good. I will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be baked into the rendering code.
Description
Implementation of #552
Checklist
src/towncrier/newsfragments/. Describe yourchange and include important information. Your change will be included in the public release notes.
docs/tutorial.rstis still up-to-date.docs/cli.rstreflects those changes.docs/configuration.rstreflects those changes.