Closed
Conversation
2 tasks
Member
|
Do you still want to do this Adi? Or wanna start fresh? (I support the change, but this branch is very stale) |
Member
Author
|
I still would like to have a simple string as the version for towncrier. |
Member
Author
|
This can be closed as there is #491 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #308
To simplify the number of dependencies towncrier can use a string as its version.
Also, when finding the version of a project, just use
str()on the project version instancce.project using
incrementalare still supported, as str(incremental.Version) does not return what we want... and is ok to keep incrementla for backwards compatibility.Todo
Checklist
src/towncrier/newsfragments/. Describe yourchange and include important information. Your change will be included in the public release notes.