Skip to content

Stop writing title twice when title_format is specified#356

Merged
adiroiban merged 2 commits intotwisted:masterfrom
pquentin:stop-writing-title-twice
Sep 22, 2021
Merged

Stop writing title twice when title_format is specified#356
adiroiban merged 2 commits intotwisted:masterfrom
pquentin:stop-writing-title-twice

Conversation

@pquentin
Copy link
Copy Markdown
Contributor

@pquentin pquentin commented Jul 16, 2021

Closes #346

The title is already rendered in content. This does not fix draft mode, but that is recorded in a separate issue.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2021

Codecov Report

Merging #356 (b2bcd8c) into master (f414111) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   96.82%   96.81%   -0.01%     
==========================================
  Files          20       20              
  Lines        1195     1194       -1     
  Branches      108      108              
==========================================
- Hits         1157     1156       -1     
  Misses         20       20              
  Partials       18       18              
Impacted Files Coverage Δ
src/towncrier/_writer.py 88.00% <ø> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f414111...b2bcd8c. Read the comment docs.

@pquentin
Copy link
Copy Markdown
Contributor Author

To be clear, the coverage isn't actually decreasing, it's just that I removed a line that was tested.

@decaz
Copy link
Copy Markdown

decaz commented Sep 21, 2021

@adiroiban @graingert @altendky @hukkin could you merge and release it, please? If the change is correct, of course :)

@adiroiban
Copy link
Copy Markdown
Member

Sorry for the delay. Let's merge this :)

Yes. coverage is expected to decrease when removing a file. I will fix it as part of the release branch.

@adiroiban adiroiban merged commit 0e6a479 into twisted:master Sep 22, 2021
@pquentin pquentin deleted the stop-writing-title-twice branch September 23, 2021 10:21
@adiroiban
Copy link
Copy Markdown
Member

I don't think that i will have time to do a release soon.
The release process is here and I think that anyone can create the release branch https://github.com/twisted/towncrier/blob/master/CONTRIBUTING.rst

I can review the release and if need i can create the tag for the release.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

title repeated twice when title_format is set

3 participants