twisted-alike (so similar) automatic publishing on gha#315
twisted-alike (so similar) automatic publishing on gha#315altendky merged 32 commits intotwisted:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 96.78% 96.78%
=======================================
Files 20 20
Lines 1183 1183
Branches 106 106
=======================================
Hits 1145 1145
Misses 20 20
Partials 18 18
Continue to review full report at Codecov.
|
|
This looks good. Then update the version to 21.3.dev1 and push that tag to make sure publishing to public repo works. Then we can merge this and delete the dev1 release from PyPi. Thanks! |
adiroiban
left a comment
There was a problem hiding this comment.
Wonderful work. Thanks! Looking forward to the public release :)
| on: | ||
| push: | ||
| branches: [ master ] | ||
| tags: [ "**" ] |
There was a problem hiding this comment.
*: Matches zero or more characters, but does not match the / character. For example, Octo* matches Octocat.
**: Matches zero or more of any character.
So it will match even if the tag ends up having a / in it. Not something we need, just my default at this point when saying 'anything'.
src/towncrier/_version.py
Outdated
| from incremental import Version | ||
|
|
||
| __version__ = Version("towncrier", 19, 2, 0) | ||
| __version__ = Version("towncrier", 21, 3, 0, dev=1) |
There was a problem hiding this comment.
Maybe use dev4 as this was the last released ?
| __version__ = Version("towncrier", 21, 3, 0, dev=1) | |
| __version__ = Version("towncrier", 21, 3, 0, dev=4) |
There was a problem hiding this comment.
Huh... I definitely didn't mean to do this, lemme find where I lost that. Thanks.
There was a problem hiding this comment.
Yeah, merge and fork and branch and PR and everything more confusion. Sorry, thanks. There was something else missing so this is a good catch.
Stalled on:
Add build-system to pyproject.toml for pep517 (tox-wheel) #314Add build-system to pyproject.toml for PEP 517 (-m build) #323 (probably) is needed as the Twisted setup this comes from uses PEP 517 builds.