Fix the use of -mtowncrier. #163#170
Fix the use of -mtowncrier. #163#170glyph merged 4 commits intotwisted:masterfrom nedbat:nedbat/fix-dash-m-invocation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
=======================================
Coverage 89.49% 89.49%
=======================================
Files 11 11
Lines 438 438
Branches 87 87
=======================================
Hits 392 392
Misses 25 25
Partials 21 21 Continue to review full report at Codecov.
|
|
Also need this. |
|
@charris I don't know what you are referring to. Is there a larger conversation somewhere? Or did you mean to link to something that should be included in this PR? |
|
I run several versions of Python for testing and development, plus upgrading the OS twice a year. In that circumstance it is helpful to have towncrier work as a module so as to keep track of which Python it is installed with. |
src/towncrier/test/test_project.py
Outdated
| with open("pyproject.toml", "w") as f: | ||
| f.write('[tool.towncrier]\n' 'directory = "news"\n') | ||
| os.makedirs("news") | ||
| out = check_output(["python", "-m", "towncrier", "--help"]) |
There was a problem hiding this comment.
Probably should use sys.executable instead of 'python' here, to avoid relying on PATH
There was a problem hiding this comment.
...hmm I didn't know this would show up as a "review", my intention was just to comment.
glyph
left a comment
There was a problem hiding this comment.
Thanks ned! A nice improvement to test coverage.
This makes the -m invocation work.
I added a test, but:
Let me know if I should change anything.