Skip to content

fix: requirements changes#726

Merged
tiwarishubham635 merged 2 commits intomainfrom
requirement_changes
Oct 10, 2023
Merged

fix: requirements changes#726
tiwarishubham635 merged 2 commits intomainfrom
requirement_changes

Conversation

@tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Oct 10, 2023

Fixes

Adding cython as dependency to support aiohttp wheel creation
Issue: I made changes for java files in twilio oai generator and tests for python are failing - see logs here
twilio/twilio-oai-generator#527
I found the aio-libs/aiohttp#6600 (comment)

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tiwarishubham635
Copy link
Contributor Author

  1. Issue: I made changes for java files in twilio oai generator and tests for python are failing - see logs here
  2. PR Link
  3. I found the fix here

@tiwarishubham635 tiwarishubham635 merged commit b5e7032 into main Oct 10, 2023
@tiwarishubham635 tiwarishubham635 deleted the requirement_changes branch October 10, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants