Skip to content

chore: reinstate npm install before npm publish#1161

Merged
tiwarishubham635 merged 2 commits intomainfrom
fix_empty_npm_pack
Dec 18, 2025
Merged

chore: reinstate npm install before npm publish#1161
tiwarishubham635 merged 2 commits intomainfrom
fix_empty_npm_pack

Conversation

@tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Dec 18, 2025

Fixes

In #1155 the npm install was mistakenly replaced with npm install -g npm@latest.
The difference is that the former installs all the dependencies, run prepublish scripts to generate lib folder and this goes into the npm.
While the latter only installs npm's latest version

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@tiwarishubham635 tiwarishubham635 changed the title chore: reinstate npm install chore: reinstate npm install in Deploy step Dec 18, 2025
@tiwarishubham635 tiwarishubham635 changed the title chore: reinstate npm install in Deploy step chore: reinstate npm install before npm publish Dec 18, 2025
@sonarqubecloud
Copy link

@tiwarishubham635 tiwarishubham635 merged commit beee846 into main Dec 18, 2025
21 checks passed
@tiwarishubham635 tiwarishubham635 deleted the fix_empty_npm_pack branch December 18, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants