Fix cycle() with non-countable ArrayAccess+Traversable objects#4713
Merged
fabpot merged 1 commit intotwigphp:3.xfrom Nov 25, 2025
Merged
Fix cycle() with non-countable ArrayAccess+Traversable objects#4713fabpot merged 1 commit intotwigphp:3.xfrom
fabpot merged 1 commit intotwigphp:3.xfrom
Conversation
aa7666e to
d7e493a
Compare
stof
reviewed
Nov 23, 2025
d7e493a to
473653d
Compare
fabpot
approved these changes
Nov 25, 2025
Contributor
|
Thank you @yoeunes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
cycle()with an object that implements\ArrayAccessand\Traversablebut is not\Countable, the function currently returns the object instance immediately after triggering the deprecation notice.This prevents the value from being converted to an array, causing the cycle logic to fail or return the object itself.
This PR removes the early return to ensure
self::toArray()is called, allowing these objects to be cycled correctly as expected.How to test
Related to #4241